diff options
author | Julia Lawall <Julia.Lawall@lip6.fr> | 2019-02-23 14:20:36 +0100 |
---|---|---|
committer | Jens Wiklander <jens.wiklander@linaro.org> | 2019-02-28 10:23:04 +0100 |
commit | c7c0d8df0b94a67377555a550b8d66ee2ad2f4ed (patch) | |
tree | 99d2bdc354865d42494973fbd1eaff2e089566f4 /drivers | |
parent | 49a57857aeea06ca831043acbb0fa5e0f50602fd (diff) | |
download | linux-stable-c7c0d8df0b94a67377555a550b8d66ee2ad2f4ed.tar.gz linux-stable-c7c0d8df0b94a67377555a550b8d66ee2ad2f4ed.tar.bz2 linux-stable-c7c0d8df0b94a67377555a550b8d66ee2ad2f4ed.zip |
tee: optee: add missing of_node_put after of_device_is_available
Add an of_node_put when a tested device node is not available.
The semantic patch that fixes this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@@
identifier f;
local idexpression e;
expression x;
@@
e = f(...);
... when != of_node_put(e)
when != x = e
when != e = x
when any
if (<+...of_device_is_available(e)...+>) {
... when != of_node_put(e)
(
return e;
|
+ of_node_put(e);
return ...;
)
}
// </smpl>
Fixes: db878f76b9ff ("tee: optee: take DT status property into account")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
Diffstat (limited to 'drivers')
-rw-r--r-- | drivers/tee/optee/core.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/drivers/tee/optee/core.c b/drivers/tee/optee/core.c index e5efce3c08e2..947f9b28de9e 100644 --- a/drivers/tee/optee/core.c +++ b/drivers/tee/optee/core.c @@ -699,8 +699,10 @@ static int __init optee_driver_init(void) return -ENODEV; np = of_find_matching_node(fw_np, optee_match); - if (!np || !of_device_is_available(np)) + if (!np || !of_device_is_available(np)) { + of_node_put(np); return -ENODEV; + } optee = optee_probe(np); of_node_put(np); |