summaryrefslogtreecommitdiffstats
path: root/drivers
diff options
context:
space:
mode:
authorRussell King (Oracle) <rmk+kernel@armlinux.org.uk>2022-03-07 12:13:30 +0000
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-03-16 14:26:43 +0100
commit811aace34e5b62176feb35f842273f41a2123349 (patch)
treecabb2838413c1b29d1a2453c05282cf3150da3d6 /drivers
parent13c3b2dfcf12b6fbfac8579591225873e0560dd8 (diff)
downloadlinux-stable-811aace34e5b62176feb35f842273f41a2123349.tar.gz
linux-stable-811aace34e5b62176feb35f842273f41a2123349.tar.bz2
linux-stable-811aace34e5b62176feb35f842273f41a2123349.zip
net: dsa: mt7530: fix incorrect test in mt753x_phylink_validate()
[ Upstream commit e5417cbf7ab5df1632e68fe7d9e6331fc0e7dbd6 ] Discussing one of the tests in mt753x_phylink_validate() with Landen Chao confirms that the "||" should be "&&". Fix this. Fixes: c288575f7810 ("net: dsa: mt7530: Add the support of MT7531 switch") Signed-off-by: Russell King (Oracle) <rmk+kernel@armlinux.org.uk> Link: https://lore.kernel.org/r/E1nRCF0-00CiXD-7q@rmk-PC.armlinux.org.uk Signed-off-by: Paolo Abeni <pabeni@redhat.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
-rw-r--r--drivers/net/dsa/mt7530.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/dsa/mt7530.c b/drivers/net/dsa/mt7530.c
index fb59efc7f926..14bf1828cbba 100644
--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -2928,7 +2928,7 @@ mt753x_phylink_validate(struct dsa_switch *ds, int port,
phylink_set_port_modes(mask);
- if (state->interface != PHY_INTERFACE_MODE_TRGMII ||
+ if (state->interface != PHY_INTERFACE_MODE_TRGMII &&
!phy_interface_mode_is_8023z(state->interface)) {
phylink_set(mask, 10baseT_Half);
phylink_set(mask, 10baseT_Full);