diff options
| author | Jiapeng Chong <jiapeng.chong@linux.alibaba.com> | 2021-08-13 14:40:42 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-09-30 10:09:23 +0200 |
| commit | b869901caba41b4b4529d274ab2077cc87d13cbf (patch) | |
| tree | e5c7e65d2dbf4b70c633fb134b26183220f81985 /drivers | |
| parent | 0ebc3e688f54a71d680ae436ed6879ebbba4f437 (diff) | |
| download | linux-stable-b869901caba41b4b4529d274ab2077cc87d13cbf.tar.gz linux-stable-b869901caba41b4b4529d274ab2077cc87d13cbf.tar.bz2 linux-stable-b869901caba41b4b4529d274ab2077cc87d13cbf.zip | |
fpga: machxo2-spi: Fix missing error code in machxo2_write_complete()
[ Upstream commit a1e4470823d99e75b596748086e120dea169ed3c ]
The error code is missing in this code scenario, add the error code
'-EINVAL' to the return value 'ret'.
Eliminate the follow smatch warning:
drivers/fpga/machxo2-spi.c:341 machxo2_write_complete()
warn: missing error code 'ret'.
[mdf@kernel.org: Reworded commit message]
Fixes: 88fb3a002330 ("fpga: lattice machxo2: Add Lattice MachXO2 support")
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
Signed-off-by: Moritz Fischer <mdf@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'drivers')
| -rw-r--r-- | drivers/fpga/machxo2-spi.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c index 2fd097c3994b..37e54e375528 100644 --- a/drivers/fpga/machxo2-spi.c +++ b/drivers/fpga/machxo2-spi.c @@ -334,6 +334,7 @@ static int machxo2_write_complete(struct fpga_manager *mgr, break; if (++refreshloop == MACHXO2_MAX_REFRESH_LOOP) { machxo2_cleanup(mgr); + ret = -EINVAL; goto fail; } } while (1); |