summaryrefslogtreecommitdiffstats
path: root/fs/ceph
diff options
context:
space:
mode:
authorSage Weil <sage@newdream.net>2011-05-19 11:21:05 -0700
committerSage Weil <sage@newdream.net>2011-05-19 11:21:05 -0700
commit0da5d70369e87f80adf794080cfff1ca15a34198 (patch)
treeb9d2fcaa52903e1c9b87ad7edfc24fb294320bce /fs/ceph
parent3b663780347ce532b08be1c859b1df14f0eea4c8 (diff)
downloadlinux-stable-0da5d70369e87f80adf794080cfff1ca15a34198.tar.gz
linux-stable-0da5d70369e87f80adf794080cfff1ca15a34198.tar.bz2
linux-stable-0da5d70369e87f80adf794080cfff1ca15a34198.zip
libceph: handle connection reopen race with callbacks
If a connection is closed and/or reopened (ceph_con_close, ceph_con_open) it can race with a callback. con_work does various state checks for closed or reopened sockets at the beginning, but drops con->mutex before making callbacks. We need to check for state bit changes after retaking the lock to ensure we restart con_work and execute those CLOSED/OPENING tests or else we may end up operating under stale assumptions. In Jim's case, this was causing 'bad tag' errors. There are four cases where we re-take the con->mutex inside con_work: catch them all and return EAGAIN from try_{read,write} so that we can restart con_work. Reported-by: Jim Schutt <jaschut@sandia.gov> Tested-by: Jim Schutt <jaschut@sandia.gov> Signed-off-by: Sage Weil <sage@newdream.net>
Diffstat (limited to 'fs/ceph')
0 files changed, 0 insertions, 0 deletions