diff options
| author | Eugene Korenevsky <ekorenevsky@astralinux.ru> | 2021-04-16 10:35:30 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-11 14:47:15 +0200 |
| commit | 23d7b4a8f77ae1252ac1a0c496ec3b603f85f593 (patch) | |
| tree | c9e04426e3368ddf285be66952d8908604a32224 /fs/cifs | |
| parent | aaa0faa5c28a91c362352d6b35dc3ed10df56fb0 (diff) | |
| download | linux-stable-23d7b4a8f77ae1252ac1a0c496ec3b603f85f593.tar.gz linux-stable-23d7b4a8f77ae1252ac1a0c496ec3b603f85f593.tar.bz2 linux-stable-23d7b4a8f77ae1252ac1a0c496ec3b603f85f593.zip | |
cifs: fix out-of-bound memory access when calling smb3_notify() at mount point
commit a637f4ae037e1e0604ac008564934d63261a8fd1 upstream.
If smb3_notify() is called at mount point of CIFS, build_path_from_dentry()
returns the pointer to kmalloc-ed memory with terminating zero (this is
empty FileName to be passed to SMB2 CREATE request). This pointer is assigned
to the `path` variable.
Then `path + 1` (to skip first backslash symbol) is passed to
cifs_convert_path_to_utf16(). This is incorrect for empty path and causes
out-of-bound memory access.
Get rid of this "increase by one". cifs_convert_path_to_utf16() already
contains the check for leading backslash in the path.
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=212693
CC: <stable@vger.kernel.org> # v5.6+
Signed-off-by: Eugene Korenevsky <ekorenevsky@astralinux.ru>
Signed-off-by: Steve French <stfrench@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/cifs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index 87392805e1a7..7f3ac605b05e 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -2174,7 +2174,7 @@ smb3_notify(const unsigned int xid, struct file *pfile, cifs_sb = CIFS_SB(inode->i_sb); - utf16_path = cifs_convert_path_to_utf16(path + 1, cifs_sb); + utf16_path = cifs_convert_path_to_utf16(path, cifs_sb); if (utf16_path == NULL) { rc = -ENOMEM; goto notify_exit; |