summaryrefslogtreecommitdiffstats
path: root/fs/efivarfs
diff options
context:
space:
mode:
authorPhillip Lougher <phillip@squashfs.org.uk>2021-05-14 17:27:16 -0700
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-05-19 10:13:10 +0200
commit2ed1d90162a0c0683ecbe0c4802187fa22d641c3 (patch)
treef69b50ba2a41539b3638b3faa5bd1c70d580c515 /fs/efivarfs
parentadbd8a2a8cc05d9e501f93e5c95c59307874cc99 (diff)
downloadlinux-stable-2ed1d90162a0c0683ecbe0c4802187fa22d641c3.tar.gz
linux-stable-2ed1d90162a0c0683ecbe0c4802187fa22d641c3.tar.bz2
linux-stable-2ed1d90162a0c0683ecbe0c4802187fa22d641c3.zip
squashfs: fix divide error in calculate_skip()
commit d6e621de1fceb3b098ebf435ef7ea91ec4838a1a upstream. Sysbot has reported a "divide error" which has been identified as being caused by a corrupted file_size value within the file inode. This value has been corrupted to a much larger value than expected. Calculate_skip() is passed i_size_read(inode) >> msblk->block_log. Due to the file_size value corruption this overflows the int argument/variable in that function, leading to the divide error. This patch changes the function to use u64. This will accommodate any unexpectedly large values due to corruption. The value returned from calculate_skip() is clamped to be never more than SQUASHFS_CACHED_BLKS - 1, or 7. So file_size corruption does not lead to an unexpectedly large return result here. Link: https://lkml.kernel.org/r/20210507152618.9447-1-phillip@squashfs.org.uk Signed-off-by: Phillip Lougher <phillip@squashfs.org.uk> Reported-by: <syzbot+e8f781243ce16ac2f962@syzkaller.appspotmail.com> Reported-by: <syzbot+7b98870d4fec9447b951@syzkaller.appspotmail.com> Cc: <stable@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/efivarfs')
0 files changed, 0 insertions, 0 deletions