summaryrefslogtreecommitdiffstats
path: root/fs/ext4/inode.c
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2019-05-23 23:35:28 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-06-11 12:23:50 +0200
commit75d63b131b73fefd9c1ef81e2ac96661c38ebba1 (patch)
tree051d809d01c8411789f7234ddc56dee712335ee7 /fs/ext4/inode.c
parent31943685dd499b0599113e6db5ee9c462e0e7e6a (diff)
downloadlinux-stable-75d63b131b73fefd9c1ef81e2ac96661c38ebba1.tar.gz
linux-stable-75d63b131b73fefd9c1ef81e2ac96661c38ebba1.tar.bz2
linux-stable-75d63b131b73fefd9c1ef81e2ac96661c38ebba1.zip
ext4: do not delete unlinked inode from orphan list on failed truncate
commit ee0ed02ca93ef1ecf8963ad96638795d55af2c14 upstream. It is possible that unlinked inode enters ext4_setattr() (e.g. if somebody calls ftruncate(2) on unlinked but still open file). In such case we should not delete the inode from the orphan list if truncate fails. Note that this is mostly a theoretical concern as filesystem is corrupted if we reach this path anyway but let's be consistent in our orphan handling. Reviewed-by: Ira Weiny <ira.weiny@intel.com> Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Cc: stable@kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4/inode.c')
-rw-r--r--fs/ext4/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index 181db3c7f5d1..063c5991f095 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -4944,7 +4944,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr)
up_write(&EXT4_I(inode)->i_data_sem);
ext4_journal_stop(handle);
if (error) {
- if (orphan)
+ if (orphan && inode->i_nlink)
ext4_orphan_del(NULL, inode);
goto err_out;
}