diff options
| author | Dave Jiang <dave.jiang@intel.com> | 2018-05-30 13:03:46 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-07-11 16:29:22 +0200 |
| commit | 8214347c260b0839c007ec4882e180fca1b6a077 (patch) | |
| tree | a7e11700f3aac7acaff6181e67e4dc3be21a54c0 /fs/ext4/super.c | |
| parent | a19385766b4faa1e27aff8b677e2be6a0f03afe4 (diff) | |
| download | linux-stable-8214347c260b0839c007ec4882e180fca1b6a077.tar.gz linux-stable-8214347c260b0839c007ec4882e180fca1b6a077.tar.bz2 linux-stable-8214347c260b0839c007ec4882e180fca1b6a077.zip | |
dax: change bdev_dax_supported() to support boolean returns
commit 80660f20252d6f76c9f203874ad7c7a4a8508cf8 upstream.
The function return values are confusing with the way the function is
named. We expect a true or false return value but it actually returns
0/-errno. This makes the code very confusing. Changing the return values
to return a bool where if DAX is supported then return true and no DAX
support returns false.
Signed-off-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4/super.c')
| -rw-r--r-- | fs/ext4/super.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/fs/ext4/super.c b/fs/ext4/super.c index 3289ec862192..fc32a67a7a19 100644 --- a/fs/ext4/super.c +++ b/fs/ext4/super.c @@ -3770,8 +3770,7 @@ static int ext4_fill_super(struct super_block *sb, void *data, int silent) " that may contain inline data"); goto failed_mount; } - err = bdev_dax_supported(sb->s_bdev, blocksize); - if (err) + if (!bdev_dax_supported(sb->s_bdev, blocksize)) goto failed_mount; } |