diff options
| author | Jun Nie <jun.nie@linaro.org> | 2023-01-03 09:45:17 +0800 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-03-11 16:31:52 +0100 |
| commit | 21f6a80d9234422e2eb445734b22c78fc5bf6719 (patch) | |
| tree | 574d76f3b2dc5cfc69e017f1936018c91e84fdd3 /fs/ext4 | |
| parent | f5cdc6a7339f250d44d4d469ed7a474ac0d6c7a7 (diff) | |
| download | linux-stable-21f6a80d9234422e2eb445734b22c78fc5bf6719.tar.gz linux-stable-21f6a80d9234422e2eb445734b22c78fc5bf6719.tar.bz2 linux-stable-21f6a80d9234422e2eb445734b22c78fc5bf6719.zip | |
ext4: refuse to create ea block when umounted
commit f31173c19901a96bb2ebf6bcfec8a08df7095c91 upstream.
The ea block expansion need to access s_root while it is
already set as NULL when umount is triggered. Refuse this
request to avoid panic.
Reported-by: syzbot+2dacb8f015bf1420155f@syzkaller.appspotmail.com
Link: https://syzkaller.appspot.com/bug?id=3613786cb88c93aa1c6a279b1df6a7b201347d08
Link: https://lore.kernel.org/r/20230103014517.495275-3-jun.nie@linaro.org
Cc: stable@kernel.org
Signed-off-by: Jun Nie <jun.nie@linaro.org>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/xattr.c | 7 |
1 files changed, 7 insertions, 0 deletions
diff --git a/fs/ext4/xattr.c b/fs/ext4/xattr.c index ae73fa4adf55..23334cfeac55 100644 --- a/fs/ext4/xattr.c +++ b/fs/ext4/xattr.c @@ -1436,6 +1436,13 @@ static struct inode *ext4_xattr_inode_create(handle_t *handle, uid_t owner[2] = { i_uid_read(inode), i_gid_read(inode) }; int err; + if (inode->i_sb->s_root == NULL) { + ext4_warning(inode->i_sb, + "refuse to create EA inode when umounting"); + WARN_ON(1); + return ERR_PTR(-EINVAL); + } + /* * Let the next inode be the goal, so we try and allocate the EA inode * in the same group, or nearby one. |