summaryrefslogtreecommitdiffstats
path: root/fs/ext4
diff options
context:
space:
mode:
authorTheodore Ts'o <tytso@mit.edu>2023-05-12 15:16:27 -0400
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2023-05-17 11:13:27 +0200
commitc012309abecb6f9e2f628c0dbf7c74d06ef2640a (patch)
tree338464f093416377b14e9a5d30052c0a48fc0e6a /fs/ext4
parent3d7b8fbcd2273e2b9f4c6de5ce2f4c0cd3cb1205 (diff)
downloadlinux-stable-c012309abecb6f9e2f628c0dbf7c74d06ef2640a.tar.gz
linux-stable-c012309abecb6f9e2f628c0dbf7c74d06ef2640a.tar.bz2
linux-stable-c012309abecb6f9e2f628c0dbf7c74d06ef2640a.zip
ext4: bail out of ext4_xattr_ibody_get() fails for any reason
commit 2a534e1d0d1591e951f9ece2fb460b2ff92edabd upstream. In ext4_update_inline_data(), if ext4_xattr_ibody_get() fails for any reason, it's best if we just fail as opposed to stumbling on, especially if the failure is EFSCORRUPTED. Cc: stable@kernel.org Signed-off-by: Theodore Ts'o <tytso@mit.edu> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4')
-rw-r--r--fs/ext4/inline.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c
index 980a24b98b17..71bb3cfc5933 100644
--- a/fs/ext4/inline.c
+++ b/fs/ext4/inline.c
@@ -358,7 +358,7 @@ static int ext4_update_inline_data(handle_t *handle, struct inode *inode,
error = ext4_xattr_ibody_get(inode, i.name_index, i.name,
value, len);
- if (error == -ENODATA)
+ if (error < 0)
goto out;
BUFFER_TRACE(is.iloc.bh, "get_write_access");