diff options
| author | Jan Kara <jack@suse.cz> | 2019-05-23 23:35:28 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-05-31 06:46:00 -0700 |
| commit | 71e430fd593b2627baaa67e808ff27131b1418e0 (patch) | |
| tree | 16cfc5d6b9e5fe1b2572accb969c8905e0cee5df /fs/ext4 | |
| parent | 1d84eb87efceb7bfbe52d7f3539af6c2e9c86870 (diff) | |
| download | linux-stable-71e430fd593b2627baaa67e808ff27131b1418e0.tar.gz linux-stable-71e430fd593b2627baaa67e808ff27131b1418e0.tar.bz2 linux-stable-71e430fd593b2627baaa67e808ff27131b1418e0.zip | |
ext4: do not delete unlinked inode from orphan list on failed truncate
commit ee0ed02ca93ef1ecf8963ad96638795d55af2c14 upstream.
It is possible that unlinked inode enters ext4_setattr() (e.g. if
somebody calls ftruncate(2) on unlinked but still open file). In such
case we should not delete the inode from the orphan list if truncate
fails. Note that this is mostly a theoretical concern as filesystem is
corrupted if we reach this path anyway but let's be consistent in our
orphan handling.
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
Signed-off-by: Jan Kara <jack@suse.cz>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Cc: stable@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ext4')
| -rw-r--r-- | fs/ext4/inode.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c index 67e8aa35197e..82dee8addb4b 100644 --- a/fs/ext4/inode.c +++ b/fs/ext4/inode.c @@ -5596,7 +5596,7 @@ int ext4_setattr(struct dentry *dentry, struct iattr *attr) up_write(&EXT4_I(inode)->i_data_sem); ext4_journal_stop(handle); if (error) { - if (orphan) + if (orphan && inode->i_nlink) ext4_orphan_del(NULL, inode); goto err_out; } |