diff options
author | Chao Yu <yuchao0@huawei.com> | 2017-02-08 17:39:45 +0800 |
---|---|---|
committer | Jaegeuk Kim <jaegeuk@kernel.org> | 2017-02-23 10:10:52 -0800 |
commit | d260081ccf37f57b74396ec48f415f27d1b01b13 (patch) | |
tree | 1e7cd5fcda412d400209c061340b938fd9d8e122 /fs/f2fs/xattr.c | |
parent | 2ad0ef846b38288103d8373d1196c465df2c4d7d (diff) | |
download | linux-stable-d260081ccf37f57b74396ec48f415f27d1b01b13.tar.gz linux-stable-d260081ccf37f57b74396ec48f415f27d1b01b13.tar.bz2 linux-stable-d260081ccf37f57b74396ec48f415f27d1b01b13.zip |
f2fs: change recovery policy of xattr node block
Currently, if we call fsync after updating the xattr date belongs to the
file, f2fs needs to trigger checkpoint to keep xattr data consistent. But,
this policy cause low performance as checkpoint will block most foreground
operations and cause unneeded and unrelated IOs around checkpoint.
This patch will reuse regular file recovery policy for xattr node block,
so, we change to write xattr node block tagged with fsync flag to warm
area instead of cold area, and during recovery, we search warm node chain
for fsynced xattr block, and do the recovery.
So, for below application IO pattern, performance can be improved
obviously:
- touch file
- create/update/delete xattr entry in file
- fsync file
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Diffstat (limited to 'fs/f2fs/xattr.c')
-rw-r--r-- | fs/f2fs/xattr.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/fs/f2fs/xattr.c b/fs/f2fs/xattr.c index f7482635a57d..b50f6b581a71 100644 --- a/fs/f2fs/xattr.c +++ b/fs/f2fs/xattr.c @@ -458,8 +458,6 @@ static inline int write_all_xattrs(struct inode *inode, __u32 hsize, set_page_dirty(xpage); f2fs_put_page(xpage, 1); - /* need to checkpoint during fsync */ - F2FS_I(inode)->xattr_ver = cur_cp_version(F2FS_CKPT(sbi)); return 0; } |