summaryrefslogtreecommitdiffstats
path: root/fs/jbd/commit.c
diff options
context:
space:
mode:
authorHidehiro Kawai <hidehiro.kawai.ez@hitachi.com>2008-10-18 20:27:53 -0700
committerLinus Torvalds <torvalds@linux-foundation.org>2008-10-20 08:52:36 -0700
commitd1645e526a1e5842c9ac433d73419ba886676cf3 (patch)
treedaa856759312e60b0fcde672e805ae35da327ece /fs/jbd/commit.c
parent60c11d2abf4ef811d0ce3ea34279746729c4c6fc (diff)
downloadlinux-stable-d1645e526a1e5842c9ac433d73419ba886676cf3.tar.gz
linux-stable-d1645e526a1e5842c9ac433d73419ba886676cf3.tar.bz2
linux-stable-d1645e526a1e5842c9ac433d73419ba886676cf3.zip
jbd: abort when failed to log metadata buffers
If we failed to write metadata buffers to the journal space and succeeded to write the commit record, stale data can be written back to the filesystem as metadata in the recovery phase. To avoid this, when we failed to write out metadata buffers, abort the journal before writing the commit record. Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com> Acked-by: Jan Kara <jack@suse.cz> Cc: <linux-ext4@vger.kernel.org> Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'fs/jbd/commit.c')
-rw-r--r--fs/jbd/commit.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/jbd/commit.c b/fs/jbd/commit.c
index ae08c057e751..f1ea861b9929 100644
--- a/fs/jbd/commit.c
+++ b/fs/jbd/commit.c
@@ -762,6 +762,9 @@ wait_for_iobuf:
/* AKPM: bforget here */
}
+ if (err)
+ journal_abort(journal, err);
+
jbd_debug(3, "JBD: commit phase 6\n");
if (journal_write_commit_record(journal, commit_transaction))