diff options
author | Anirudh Rayabharam <mail@anirudhrb.com> | 2021-04-25 23:03:53 +0530 |
---|---|---|
committer | Sasha Levin <sashal@kernel.org> | 2021-06-30 08:48:45 -0400 |
commit | 8c064eece9a51856f3f275104520c7e3017fc5c0 (patch) | |
tree | 0dd5ee04d297a6b9338c9894915574ce14e789cb /fs/kernfs | |
parent | 43ab41d973e3e3be389a2819477d8054b9e61903 (diff) | |
download | linux-stable-8c064eece9a51856f3f275104520c7e3017fc5c0.tar.gz linux-stable-8c064eece9a51856f3f275104520c7e3017fc5c0.tar.bz2 linux-stable-8c064eece9a51856f3f275104520c7e3017fc5c0.zip |
HID: usbhid: fix info leak in hid_submit_ctrl
[ Upstream commit 6be388f4a35d2ce5ef7dbf635a8964a5da7f799f ]
In hid_submit_ctrl(), the way of calculating the report length doesn't
take into account that report->size can be zero. When running the
syzkaller reproducer, a report of size 0 causes hid_submit_ctrl) to
calculate transfer_buffer_length as 16384. When this urb is passed to
the usb core layer, KMSAN reports an info leak of 16384 bytes.
To fix this, first modify hid_report_len() to account for the zero
report size case by using DIV_ROUND_UP for the division. Then, call it
from hid_submit_ctrl().
Reported-by: syzbot+7c2bb71996f95a82524c@syzkaller.appspotmail.com
Signed-off-by: Anirudh Rayabharam <mail@anirudhrb.com>
Acked-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/kernfs')
0 files changed, 0 insertions, 0 deletions