diff options
author | Trond Myklebust <trond.myklebust@primarydata.com> | 2015-01-02 15:05:25 -0500 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2015-01-22 15:42:56 +0000 |
commit | 44a553d0daea6f5e836701b25949b60f30ec2371 (patch) | |
tree | e98e1ef32cc9b3e3018eee4cac83b656050f4174 /fs/lockd | |
parent | 2583738119679d8d1d67c2d6f221ce1a1046328e (diff) | |
download | linux-stable-44a553d0daea6f5e836701b25949b60f30ec2371.tar.gz linux-stable-44a553d0daea6f5e836701b25949b60f30ec2371.tar.bz2 linux-stable-44a553d0daea6f5e836701b25949b60f30ec2371.zip |
LOCKD: Fix a race when initialising nlmsvc_timeout
commit 06bed7d18c2c07b3e3eeadf4bd357f6e806618cc upstream.
This commit fixes a race whereby nlmclnt_init() first starts the lockd
daemon, and then calls nlm_bind_host() with the expectation that
nlmsvc_timeout has already been initialised. Unfortunately, there is no
no synchronisation between lockd() and lockd_up() to guarantee that this
is the case.
Fix is to move the initialisation of nlmsvc_timeout into lockd_create_svc
Fixes: 9a1b6bf818e74 ("LOCKD: Don't call utsname()->nodename...")
Cc: Bruce Fields <bfields@fieldses.org>
Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>
[ luis: backported to 3.16: adjusted context ]
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'fs/lockd')
-rw-r--r-- | fs/lockd/svc.c | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c index ec9e082f9ecd..3f5a7248e771 100644 --- a/fs/lockd/svc.c +++ b/fs/lockd/svc.c @@ -137,10 +137,6 @@ lockd(void *vrqstp) dprintk("NFS locking service started (ver " LOCKD_VERSION ").\n"); - if (!nlm_timeout) - nlm_timeout = LOCKD_DFLT_TIMEO; - nlmsvc_timeout = nlm_timeout * HZ; - /* * The main request loop. We don't terminate until the last * NFS mount or NFS daemon has gone away. @@ -346,6 +342,10 @@ static struct svc_serv *lockd_create_svc(void) printk(KERN_WARNING "lockd_up: no pid, %d users??\n", nlmsvc_users); + if (!nlm_timeout) + nlm_timeout = LOCKD_DFLT_TIMEO; + nlmsvc_timeout = nlm_timeout * HZ; + serv = svc_create(&nlmsvc_program, LOCKD_BUFSIZE, NULL); if (!serv) { printk(KERN_WARNING "lockd_up: create service failed\n"); |