diff options
| author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-03-28 08:36:34 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-04-15 14:14:53 +0200 |
| commit | f8b746f5cf7c601f8b8a59d097efb4ef24eb1b3b (patch) | |
| tree | cc5ae50ee1458aed86412ea5aedbd380c63638b6 /fs/nfs/pnfs.h | |
| parent | 4c240c5a105557e4546d0836e694868f22fd09b0 (diff) | |
| download | linux-stable-f8b746f5cf7c601f8b8a59d097efb4ef24eb1b3b.tar.gz linux-stable-f8b746f5cf7c601f8b8a59d097efb4ef24eb1b3b.tar.bz2 linux-stable-f8b746f5cf7c601f8b8a59d097efb4ef24eb1b3b.zip | |
NFSv4/pNFS: Fix another issue with a list iterator pointing to the head
[ Upstream commit 7c9d845f0612e5bcd23456a2ec43be8ac43458f1 ]
In nfs4_callback_devicenotify(), if we don't find a matching entry for
the deviceid, we're left with a pointer to 'struct nfs_server' that
actually points to the list of super blocks associated with our struct
nfs_client.
Furthermore, even if we have a valid pointer, nothing pins the super
block, and so the struct nfs_server could end up getting freed while
we're using it.
Since all we want is a pointer to the struct pnfs_layoutdriver_type,
let's skip all the iteration over super blocks, and just use APIs to
find the layout driver directly.
Reported-by: Xiaomeng Tong <xiam0nd.tong@gmail.com>
Fixes: 1be5683b03a7 ("pnfs: CB_NOTIFY_DEVICEID")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs/nfs/pnfs.h')
| -rw-r--r-- | fs/nfs/pnfs.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/nfs/pnfs.h b/fs/nfs/pnfs.h index 80fafa29e567..d5d818b1ac9d 100644 --- a/fs/nfs/pnfs.h +++ b/fs/nfs/pnfs.h @@ -225,6 +225,8 @@ struct pnfs_devicelist { extern int pnfs_register_layoutdriver(struct pnfs_layoutdriver_type *); extern void pnfs_unregister_layoutdriver(struct pnfs_layoutdriver_type *); +extern const struct pnfs_layoutdriver_type *pnfs_find_layoutdriver(u32 id); +extern void pnfs_put_layoutdriver(const struct pnfs_layoutdriver_type *ld); /* nfs4proc.c */ extern size_t max_response_pages(struct nfs_server *server); |