diff options
| author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-01-06 18:24:03 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-08 18:23:09 +0100 |
| commit | 07a970dd3a176a5f4a123281dfbf14fc8035ade0 (patch) | |
| tree | bd19c46258ae892636c001c4ef649031e32b6235 /fs/nfs | |
| parent | b00b4c6faad0f21e443fb1584f7a8ea222beb0de (diff) | |
| download | linux-stable-07a970dd3a176a5f4a123281dfbf14fc8035ade0.tar.gz linux-stable-07a970dd3a176a5f4a123281dfbf14fc8035ade0.tar.bz2 linux-stable-07a970dd3a176a5f4a123281dfbf14fc8035ade0.zip | |
NFSv4: nfs_atomic_open() can race when looking up a non-regular file
commit 1751fc1db36f6f411709e143d5393f92d12137a9 upstream.
If the file type changes back to being a regular file on the server
between the failed OPEN and our LOOKUP, then we need to re-run the OPEN.
Fixes: 0dd2b474d0b6 ("nfs: implement i_op->atomic_open()")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/nfs')
| -rw-r--r-- | fs/nfs/dir.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c index f8d805c80464..f2ea5c244531 100644 --- a/fs/nfs/dir.c +++ b/fs/nfs/dir.c @@ -1631,12 +1631,17 @@ no_open: if ((lookup_flags & LOOKUP_DIRECTORY) && inode && !S_ISDIR(inode->i_mode)) res = ERR_PTR(-ENOTDIR); + else if (inode && S_ISREG(inode->i_mode)) + res = ERR_PTR(-EOPENSTALE); } else if (!IS_ERR(res)) { inode = d_inode(res); if ((lookup_flags & LOOKUP_DIRECTORY) && inode && !S_ISDIR(inode->i_mode)) { dput(res); res = ERR_PTR(-ENOTDIR); + } else if (inode && S_ISREG(inode->i_mode)) { + dput(res); + res = ERR_PTR(-EOPENSTALE); } } if (switched) { |