diff options
author | Paul Moore <pmoore@redhat.com> | 2014-12-19 18:35:53 -0500 |
---|---|---|
committer | Luis Henriques <luis.henriques@canonical.com> | 2015-01-15 10:44:42 +0000 |
commit | 1d6681827e67f9fdfbaf0e09575ba64f900bb52c (patch) | |
tree | df3cdda779d52548556dfacb9b49613425606e4a /fs/nfsd | |
parent | 8254b3a6595c58d5372e1806443bc9573297e020 (diff) | |
download | linux-stable-1d6681827e67f9fdfbaf0e09575ba64f900bb52c.tar.gz linux-stable-1d6681827e67f9fdfbaf0e09575ba64f900bb52c.tar.bz2 linux-stable-1d6681827e67f9fdfbaf0e09575ba64f900bb52c.zip |
audit: don't attempt to lookup PIDs when changing PID filtering audit rules
commit 3640dcfa4fd00cd91d88bb86250bdb496f7070c0 upstream.
Commit f1dc4867 ("audit: anchor all pid references in the initial pid
namespace") introduced a find_vpid() call when adding/removing audit
rules with PID/PPID filters; unfortunately this is problematic as
find_vpid() only works if there is a task with the associated PID
alive on the system. The following commands demonstrate a simple
reproducer.
# auditctl -D
# auditctl -l
# autrace /bin/true
# auditctl -l
This patch resolves the problem by simply using the PID provided by
the user without any additional validation, e.g. no calls to check to
see if the task/PID exists.
Cc: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <pmoore@redhat.com>
Acked-by: Eric Paris <eparis@redhat.com>
Reviewed-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'fs/nfsd')
0 files changed, 0 insertions, 0 deletions