diff options
author | Takashi Iwai <tiwai@suse.de> | 2021-05-18 10:39:39 +0200 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-05-26 11:29:06 +0200 |
commit | 02303132de22be08bc90e99b3e1eca20b8284493 (patch) | |
tree | 8bdea069db6909c8fc1e235de4d8bba66b59a9b0 /fs/orangefs/acl.c | |
parent | 5716a37020e08b3e93d2f4f7ed14ebf137029dd5 (diff) | |
download | linux-stable-02303132de22be08bc90e99b3e1eca20b8284493.tar.gz linux-stable-02303132de22be08bc90e99b3e1eca20b8284493.tar.bz2 linux-stable-02303132de22be08bc90e99b3e1eca20b8284493.zip |
ALSA: line6: Fix racy initialization of LINE6 MIDI
commit 05ca447630334c323c9e2b788b61133ab75d60d3 upstream.
The initialization of MIDI devices that are found on some LINE6
drivers are currently done in a racy way; namely, the MIDI buffer
instance is allocated and initialized in each private_init callback
while the communication with the interface is already started via
line6_init_cap_control() call before that point. This may lead to
Oops in line6_data_received() when a spurious event is received, as
reported by syzkaller.
This patch moves the MIDI initialization to line6_init_cap_control()
as well instead of the too-lately-called private_init for avoiding the
race. Also this reduces slightly more lines, so it's a win-win
change.
Reported-by: syzbot+0d2b3feb0a2887862e06@syzkallerlkml..appspotmail.com
Link: https://lore.kernel.org/r/000000000000a4be9405c28520de@google.com
Link: https://lore.kernel.org/r/20210517132725.GA50495@hyeyoo
Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20210518083939.1927-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/orangefs/acl.c')
0 files changed, 0 insertions, 0 deletions