summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorBaokun Li <libaokun1@huawei.com>2022-02-15 12:07:36 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-04-15 14:14:58 +0200
commita2d0d4b6d105b764ae4d5a9749af585b4d5174db (patch)
treedb029b924366561c9f83d3d207d430303cdc84b8 /fs/ubifs
parent5343575aa11c5d7044107d59d43f84aec01312b0 (diff)
downloadlinux-stable-a2d0d4b6d105b764ae4d5a9749af585b4d5174db.tar.gz
linux-stable-a2d0d4b6d105b764ae4d5a9749af585b4d5174db.tar.bz2
linux-stable-a2d0d4b6d105b764ae4d5a9749af585b4d5174db.zip
ubifs: rename_whiteout: correct old_dir size computing
commit 705757274599e2e064dd3054aabc74e8af31a095 upstream. When renaming the whiteout file, the old whiteout file is not deleted. Therefore, we add the old dentry size to the old dir like XFS. Otherwise, an error may be reported due to `fscki->calc_sz != fscki->size` in check_indes. Fixes: 9e0a1fff8db56ea ("ubifs: Implement RENAME_WHITEOUT") Reported-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Baokun Li <libaokun1@huawei.com> Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/dir.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 1a2e0153a070..9e466eb30dcb 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -1379,6 +1379,9 @@ static int do_rename(struct inode *old_dir, struct dentry *old_dentry,
iput(whiteout);
goto out_release;
}
+
+ /* Add the old_dentry size to the old_dir size. */
+ old_sz -= CALC_DENT_SIZE(fname_len(&old_nm));
}
lock_4_inodes(old_dir, new_dir, new_inode, whiteout);