summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorRichard Weinberger <richard@nod.at>2016-10-28 11:49:03 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-11-10 16:36:33 +0100
commitdc70a200aac2dafd2502ac1cfc1a5ca6dde6486f (patch)
tree777c205254d0d375f7eb56b3b70d3f87254d7dbd /fs/ubifs
parent0222377bb2cb1cf327be0feed117c44722b1e375 (diff)
downloadlinux-stable-dc70a200aac2dafd2502ac1cfc1a5ca6dde6486f.tar.gz
linux-stable-dc70a200aac2dafd2502ac1cfc1a5ca6dde6486f.tar.bz2
linux-stable-dc70a200aac2dafd2502ac1cfc1a5ca6dde6486f.zip
ubifs: Fix regression in ubifs_readdir()
commit a00052a296e54205cf238c75bd98d17d5d02a6db upstream. Commit c83ed4c9dbb35 ("ubifs: Abort readdir upon error") broke overlayfs support because the fix exposed an internal error code to VFS. Reported-by: Peter Rosin <peda@axentia.se> Tested-by: Peter Rosin <peda@axentia.se> Reported-by: Ralph Sennhauser <ralph.sennhauser@gmail.com> Tested-by: Ralph Sennhauser <ralph.sennhauser@gmail.com> Fixes: c83ed4c9dbb35 ("ubifs: Abort readdir upon error") Signed-off-by: Richard Weinberger <richard@nod.at> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/dir.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/fs/ubifs/dir.c b/fs/ubifs/dir.c
index 102ae0c582c1..f5d5ee43ae6e 100644
--- a/fs/ubifs/dir.c
+++ b/fs/ubifs/dir.c
@@ -454,6 +454,14 @@ out:
if (err != -ENOENT)
ubifs_err(c, "cannot find next direntry, error %d", err);
+ else
+ /*
+ * -ENOENT is a non-fatal error in this context, the TNC uses
+ * it to indicate that the cursor moved past the current directory
+ * and readdir() has to stop.
+ */
+ err = 0;
+
/* 2 is a special value indicating that there are no more direntries */
ctx->pos = 2;