summaryrefslogtreecommitdiffstats
path: root/fs/ubifs
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2021-05-11 10:12:00 +0300
committerRichard Weinberger <richard@nod.at>2021-06-18 22:04:47 +0200
commitbe076fdf8369f3b4842362c64cd681f3d498f3dd (patch)
tree04fc8d1e381f1720a2fd025a87b79bdcc4f8a24a /fs/ubifs
parenta2c2a622d41168f9fea2aa3f76b9fbaa88531aac (diff)
downloadlinux-stable-be076fdf8369f3b4842362c64cd681f3d498f3dd.tar.gz
linux-stable-be076fdf8369f3b4842362c64cd681f3d498f3dd.tar.bz2
linux-stable-be076fdf8369f3b4842362c64cd681f3d498f3dd.zip
ubifs: fix snprintf() checking
The snprintf() function returns the number of characters (not counting the NUL terminator) that it would have printed if we had space. This buffer has UBIFS_DFS_DIR_LEN characters plus one extra for the terminator. Printing UBIFS_DFS_DIR_LEN is okay but anything higher will result in truncation. Thus the comparison needs to be change from == to >. These strings are compile time constants so this patch doesn't affect runtime. Fixes: ae380ce04731 ("UBIFS: lessen the size of debugging info data structure") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Alexander Dahl <ada@thorsis.com> Signed-off-by: Richard Weinberger <richard@nod.at>
Diffstat (limited to 'fs/ubifs')
-rw-r--r--fs/ubifs/debug.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/ubifs/debug.c b/fs/ubifs/debug.c
index 1bbb9fe661b1..fc718f6178f2 100644
--- a/fs/ubifs/debug.c
+++ b/fs/ubifs/debug.c
@@ -2824,7 +2824,7 @@ void dbg_debugfs_init_fs(struct ubifs_info *c)
n = snprintf(d->dfs_dir_name, UBIFS_DFS_DIR_LEN + 1, UBIFS_DFS_DIR_NAME,
c->vi.ubi_num, c->vi.vol_id);
- if (n == UBIFS_DFS_DIR_LEN) {
+ if (n > UBIFS_DFS_DIR_LEN) {
/* The array size is too small */
return;
}