diff options
| author | Josef Bacik <josef@toxicpanda.com> | 2021-11-05 16:45:35 -0400 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-01-27 09:04:27 +0100 |
| commit | e7ef158cdf63237342262c8bfb66f39d85bc1e29 (patch) | |
| tree | fc62252aaf76c43508601ced937ba10d08a4a79c /fs | |
| parent | 65b2b7becfc2201fc3e1ed63e7fff54fde593bbb (diff) | |
| download | linux-stable-e7ef158cdf63237342262c8bfb66f39d85bc1e29.tar.gz linux-stable-e7ef158cdf63237342262c8bfb66f39d85bc1e29.tar.bz2 linux-stable-e7ef158cdf63237342262c8bfb66f39d85bc1e29.zip | |
btrfs: remove BUG_ON(!eie) in find_parent_nodes
[ Upstream commit 9f05c09d6baef789726346397438cca4ec43c3ee ]
If we're looking for leafs that point to a data extent we want to record
the extent items that point at our bytenr. At this point we have the
reference and we know for a fact that this leaf should have a reference
to our bytenr. However if there's some sort of corruption we may not
find any references to our leaf, and thus could end up with eie == NULL.
Replace this BUG_ON() with an ASSERT() and then return -EUCLEAN for the
mortals.
Signed-off-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/btrfs/backref.c | 14 |
1 files changed, 11 insertions, 3 deletions
diff --git a/fs/btrfs/backref.c b/fs/btrfs/backref.c index 0073182d4e68..3fe15d6f4087 100644 --- a/fs/btrfs/backref.c +++ b/fs/btrfs/backref.c @@ -1313,10 +1313,18 @@ again: goto out; if (!ret && extent_item_pos) { /* - * we've recorded that parent, so we must extend - * its inode list here + * We've recorded that parent, so we must extend + * its inode list here. + * + * However if there was corruption we may not + * have found an eie, return an error in this + * case. */ - BUG_ON(!eie); + ASSERT(eie); + if (!eie) { + ret = -EUCLEAN; + goto out; + } while (eie->next) eie = eie->next; eie->next = ref->inode_list; |