summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorJan Kara <jack@suse.cz>2014-10-23 14:02:47 +0200
committerLuis Henriques <luis.henriques@canonical.com>2014-11-27 11:21:44 +0000
commit859e27731a268ee8cd529e868d26ae6d8291fcf3 (patch)
treed799efe14845680e107495c63c2614f79736f5ec /fs
parentd6bd1c49447a881d235168eacc8d4d8ac8262767 (diff)
downloadlinux-stable-859e27731a268ee8cd529e868d26ae6d8291fcf3.tar.gz
linux-stable-859e27731a268ee8cd529e868d26ae6d8291fcf3.tar.bz2
linux-stable-859e27731a268ee8cd529e868d26ae6d8291fcf3.zip
nfs: Fix use of uninitialized variable in nfs_getattr()
commit 16caf5b6101d03335b386e77e9e14136f989be87 upstream. Variable 'err' needn't be initialized when nfs_getattr() uses it to check whether it should call generic_fillattr() or not. That can result in spurious error returns. Initialize 'err' properly. Signed-off-by: Jan Kara <jack@suse.cz> Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com> Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
Diffstat (limited to 'fs')
-rw-r--r--fs/nfs/inode.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index a732cbbd4e80..aa6daf535dec 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -624,7 +624,7 @@ int nfs_getattr(struct vfsmount *mnt, struct dentry *dentry, struct kstat *stat)
{
struct inode *inode = dentry->d_inode;
int need_atime = NFS_I(inode)->cache_validity & NFS_INO_INVALID_ATIME;
- int err;
+ int err = 0;
trace_nfs_getattr_enter(inode);
/* Flush out writes to the server in order to update c/mtime. */