diff options
| author | Eric W. Biederman <ebiederm@xmission.com> | 2014-12-29 13:03:41 -0600 |
|---|---|---|
| committer | Eric W. Biederman <ebiederm@xmission.com> | 2015-04-09 11:39:54 -0500 |
| commit | 7bdb11de8ee4f4ae195e2fa19efd304e0b36c63b (patch) | |
| tree | 2ee3fe90e5ac72a2b36c91947b38c3e6da9a9012 /fs | |
| parent | cd4a40174b71acd021877341684d8bb1dc8ea4ae (diff) | |
| download | linux-stable-7bdb11de8ee4f4ae195e2fa19efd304e0b36c63b.tar.gz linux-stable-7bdb11de8ee4f4ae195e2fa19efd304e0b36c63b.tar.bz2 linux-stable-7bdb11de8ee4f4ae195e2fa19efd304e0b36c63b.zip | |
mnt: Factor out unhash_mnt from detach_mnt and umount_tree
Create a function unhash_mnt that contains the common code between
detach_mnt and umount_tree, and use unhash_mnt in place of the common
code. This add a unncessary list_del_init(mnt->mnt_child) into
umount_tree but given that mnt_child is already empty this extra
line is a noop.
Cc: stable@vger.kernel.org
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/namespace.c | 21 |
1 files changed, 12 insertions, 9 deletions
diff --git a/fs/namespace.c b/fs/namespace.c index acc5583764dc..e669a3bf86e7 100644 --- a/fs/namespace.c +++ b/fs/namespace.c @@ -798,10 +798,8 @@ static void __touch_mnt_namespace(struct mnt_namespace *ns) /* * vfsmount lock must be held for write */ -static void detach_mnt(struct mount *mnt, struct path *old_path) +static void unhash_mnt(struct mount *mnt) { - old_path->dentry = mnt->mnt_mountpoint; - old_path->mnt = &mnt->mnt_parent->mnt; mnt->mnt_parent = mnt; mnt->mnt_mountpoint = mnt->mnt.mnt_root; list_del_init(&mnt->mnt_child); @@ -814,6 +812,16 @@ static void detach_mnt(struct mount *mnt, struct path *old_path) /* * vfsmount lock must be held for write */ +static void detach_mnt(struct mount *mnt, struct path *old_path) +{ + old_path->dentry = mnt->mnt_mountpoint; + old_path->mnt = &mnt->mnt_parent->mnt; + unhash_mnt(mnt); +} + +/* + * vfsmount lock must be held for write + */ void mnt_set_mountpoint(struct mount *mnt, struct mountpoint *mp, struct mount *child_mnt) @@ -1362,15 +1370,10 @@ static void umount_tree(struct mount *mnt, enum umount_tree_flags how) pin_insert_group(&p->mnt_umount, &p->mnt_parent->mnt, &unmounted); if (mnt_has_parent(p)) { - hlist_del_init(&p->mnt_mp_list); - put_mountpoint(p->mnt_mp); mnt_add_count(p->mnt_parent, -1); /* old mountpoint will be dropped when we can do that */ p->mnt_ex_mountpoint = p->mnt_mountpoint; - p->mnt_mountpoint = p->mnt.mnt_root; - p->mnt_parent = p; - p->mnt_mp = NULL; - hlist_del_init_rcu(&p->mnt_hash); + unhash_mnt(p); } change_mnt_propagation(p, MS_PRIVATE); } |