diff options
| author | Trond Myklebust <trond.myklebust@hammerspace.com> | 2022-02-15 18:05:18 -0500 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2022-02-23 11:58:40 +0100 |
| commit | d2ba21f271eb167ac2b0581598e55222b89f0f32 (patch) | |
| tree | 7699bbb1d1d146681218bd35723d35d2d9603a5d /fs | |
| parent | 67552482aee7a139ed957595db8668d28ddc2c42 (diff) | |
| download | linux-stable-d2ba21f271eb167ac2b0581598e55222b89f0f32.tar.gz linux-stable-d2ba21f271eb167ac2b0581598e55222b89f0f32.tar.bz2 linux-stable-d2ba21f271eb167ac2b0581598e55222b89f0f32.zip | |
NFS: Do not report writeback errors in nfs_getattr()
commit d19e0183a88306acda07f4a01fedeeffe2a2a06b upstream.
The result of the writeback, whether it is an ENOSPC or an EIO, or
anything else, does not inhibit the NFS client from reporting the
correct file timestamps.
Fixes: 79566ef018f5 ("NFS: Getattr doesn't require data sync semantics")
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/inode.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c index 2cdd8883b7c5..592b95ab378b 100644 --- a/fs/nfs/inode.c +++ b/fs/nfs/inode.c @@ -787,12 +787,9 @@ int nfs_getattr(const struct path *path, struct kstat *stat, goto out_no_update; /* Flush out writes to the server in order to update c/mtime. */ - if ((request_mask & (STATX_CTIME|STATX_MTIME)) && - S_ISREG(inode->i_mode)) { - err = filemap_write_and_wait(inode->i_mapping); - if (err) - goto out; - } + if ((request_mask & (STATX_CTIME | STATX_MTIME)) && + S_ISREG(inode->i_mode)) + filemap_write_and_wait(inode->i_mapping); /* * We may force a getattr if the user cares about atime. |