diff options
author | Yunlong Song <yunlong.song@huawei.com> | 2018-10-24 16:08:30 +0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-12-13 08:51:48 +0100 |
commit | 859c93a04b61de9aa9d75f8f09a7f9ab0b6af3a5 (patch) | |
tree | 6a6886ecf59f475a9541069421b80862ecf691b8 /fs | |
parent | c1054aeba939e7b14b1dc5137474fc38242cba11 (diff) | |
download | linux-stable-859c93a04b61de9aa9d75f8f09a7f9ab0b6af3a5.tar.gz linux-stable-859c93a04b61de9aa9d75f8f09a7f9ab0b6af3a5.tar.bz2 linux-stable-859c93a04b61de9aa9d75f8f09a7f9ab0b6af3a5.zip |
f2fs: fix count of seg_freed to make sec_freed correct
[ Upstream commit d6c66cd19ef322fe0d51ba09ce1b7f386acab04a ]
When sbi->segs_per_sec > 1, and if some segno has 0 valid blocks before
gc starts, do_garbage_collect will skip counting seg_freed++, and this
will cause seg_freed < sbi->segs_per_sec and finally skip sec_freed++.
Signed-off-by: Yunlong Song <yunlong.song@huawei.com>
Signed-off-by: Chao Yu <yuchao0@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r-- | fs/f2fs/gc.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c index 8c4cb1eee10a..3d98e909201d 100644 --- a/fs/f2fs/gc.c +++ b/fs/f2fs/gc.c @@ -1081,9 +1081,9 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, GET_SUM_BLOCK(sbi, segno)); f2fs_put_page(sum_page, 0); - if (get_valid_blocks(sbi, segno, false) == 0 || - !PageUptodate(sum_page) || - unlikely(f2fs_cp_error(sbi))) + if (get_valid_blocks(sbi, segno, false) == 0) + goto freed; + if (!PageUptodate(sum_page) || unlikely(f2fs_cp_error(sbi))) goto next; sum = page_address(sum_page); @@ -1110,6 +1110,7 @@ static int do_garbage_collect(struct f2fs_sb_info *sbi, stat_inc_seg_count(sbi, type, gc_type); +freed: if (gc_type == FG_GC && get_valid_blocks(sbi, segno, false) == 0) seg_freed++; |