diff options
| author | Ronnie Sahlberg <lsahlber@redhat.com> | 2019-04-10 07:47:22 +1000 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-04-27 09:36:33 +0200 |
| commit | 2fcee5eaae6ee1c2ccbe629ffd46c6674a98824c (patch) | |
| tree | 6692dce154e78369d77f8f23b2cb9580de3fd425 /fs | |
| parent | c69330a855ab4342d304f67f8c1e7d1fa2686bec (diff) | |
| download | linux-stable-2fcee5eaae6ee1c2ccbe629ffd46c6674a98824c.tar.gz linux-stable-2fcee5eaae6ee1c2ccbe629ffd46c6674a98824c.tar.bz2 linux-stable-2fcee5eaae6ee1c2ccbe629ffd46c6674a98824c.zip | |
cifs: fix handle leak in smb2_query_symlink()
commit e6d0fb7b34f264f72c33053558a360a6a734905e upstream.
If we enter smb2_query_symlink() for something that is not a symlink
and where the SMB2_open() would succeed we would never end up
closing this handle and would thus leak a handle on the server.
Fix this by immediately calling SMB2_close() on successfull open.
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
CC: Stable <stable@vger.kernel.org>
Signed-off-by: Steve French <stfrench@microsoft.com>
Reviewed-by: Pavel Shilovsky <pshilov@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/cifs/smb2ops.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/fs/cifs/smb2ops.c b/fs/cifs/smb2ops.c index d4d7d61a6fe2..2001184afe70 100644 --- a/fs/cifs/smb2ops.c +++ b/fs/cifs/smb2ops.c @@ -1906,6 +1906,8 @@ smb2_query_symlink(const unsigned int xid, struct cifs_tcon *tcon, rc = SMB2_open(xid, &oparms, utf16_path, &oplock, NULL, &err_iov, &resp_buftype); + if (!rc) + SMB2_close(xid, tcon, fid.persistent_fid, fid.volatile_fid); if (!rc || !err_iov.iov_base) { rc = -ENOENT; goto free_path; |