summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2019-08-27 13:59:17 +0300
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2019-09-21 07:18:38 +0200
commitb8632186884a030da2cd83b2e02645e521ab2bbd (patch)
treee705a36e81f8e88d4ef1b78475c862e607aefabd /fs
parent8db988a982908b7bff76e095000adabf9c29698b (diff)
downloadlinux-stable-b8632186884a030da2cd83b2e02645e521ab2bbd.tar.gz
linux-stable-b8632186884a030da2cd83b2e02645e521ab2bbd.tar.bz2
linux-stable-b8632186884a030da2cd83b2e02645e521ab2bbd.zip
cifs: Use kzfree() to zero out the password
[ Upstream commit 478228e57f81f6cb60798d54fc02a74ea7dd267e ] It's safer to zero out the password so that it can never be disclosed. Fixes: 0c219f5799c7 ("cifs: set domainName when a domain-key is used in multiuser") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: Steve French <stfrench@microsoft.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/cifs/connect.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/cifs/connect.c b/fs/cifs/connect.c
index 2beaa14519f5..85b2107e8a3d 100644
--- a/fs/cifs/connect.c
+++ b/fs/cifs/connect.c
@@ -3081,7 +3081,7 @@ cifs_set_cifscreds(struct smb_vol *vol, struct cifs_ses *ses)
rc = -ENOMEM;
kfree(vol->username);
vol->username = NULL;
- kfree(vol->password);
+ kzfree(vol->password);
vol->password = NULL;
goto out_key_put;
}