diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2021-06-03 15:37:53 +0300 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2021-06-16 11:59:44 +0200 |
| commit | 0057ecef9f324007c0ba5fcca4ddd131178ce78b (patch) | |
| tree | 5860bc10f72898f5696e7eb5daab0df897619a36 /fs | |
| parent | e3ecd9c09fcc10cf6b2bc67e2990c397c40a8c26 (diff) | |
| download | linux-stable-0057ecef9f324007c0ba5fcca4ddd131178ce78b.tar.gz linux-stable-0057ecef9f324007c0ba5fcca4ddd131178ce78b.tar.bz2 linux-stable-0057ecef9f324007c0ba5fcca4ddd131178ce78b.zip | |
NFS: Fix a potential NULL dereference in nfs_get_client()
[ Upstream commit 09226e8303beeec10f2ff844d2e46d1371dc58e0 ]
None of the callers are expecting NULL returns from nfs_get_client() so
this code will lead to an Oops. It's better to return an error
pointer. I expect that this is dead code so hopefully no one is
affected.
Fixes: 31434f496abb ("nfs: check hostname in nfs_get_client")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
| -rw-r--r-- | fs/nfs/client.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/fs/nfs/client.c b/fs/nfs/client.c index a05f77f9c21e..af838d1ed281 100644 --- a/fs/nfs/client.c +++ b/fs/nfs/client.c @@ -399,7 +399,7 @@ struct nfs_client *nfs_get_client(const struct nfs_client_initdata *cl_init) if (cl_init->hostname == NULL) { WARN_ON(1); - return NULL; + return ERR_PTR(-EINVAL); } /* see if the client already exists */ |