summaryrefslogtreecommitdiffstats
path: root/fs
diff options
context:
space:
mode:
authorDan Carpenter <dan.carpenter@oracle.com>2021-06-15 08:39:52 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-06-23 14:41:23 +0200
commit0498165c6fec26fb1832cea2f45e05913efacf4b (patch)
treee39899fa1069b53e069221ff638e210b49167545 /fs
parent2a3f74ca167e3645258e36cfac809b8c41102513 (diff)
downloadlinux-stable-0498165c6fec26fb1832cea2f45e05913efacf4b.tar.gz
linux-stable-0498165c6fec26fb1832cea2f45e05913efacf4b.tar.bz2
linux-stable-0498165c6fec26fb1832cea2f45e05913efacf4b.zip
afs: Fix an IS_ERR() vs NULL check
[ Upstream commit a33d62662d275cee22888fa7760fe09d5b9cd1f9 ] The proc_symlink() function returns NULL on error, it doesn't return error pointers. Fixes: 5b86d4ff5dce ("afs: Implement network namespacing") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Signed-off-by: David Howells <dhowells@redhat.com> cc: linux-afs@lists.infradead.org Link: https://lore.kernel.org/r/YLjMRKX40pTrJvgf@mwanda/ Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'fs')
-rw-r--r--fs/afs/main.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/fs/afs/main.c b/fs/afs/main.c
index 5cd26af2464c..d129a1a49616 100644
--- a/fs/afs/main.c
+++ b/fs/afs/main.c
@@ -196,8 +196,8 @@ static int __init afs_init(void)
goto error_fs;
afs_proc_symlink = proc_symlink("fs/afs", NULL, "../self/net/afs");
- if (IS_ERR(afs_proc_symlink)) {
- ret = PTR_ERR(afs_proc_symlink);
+ if (!afs_proc_symlink) {
+ ret = -ENOMEM;
goto error_proc;
}