diff options
| author | Heiner Kallweit <hkallweit1@gmail.com> | 2018-01-10 21:21:31 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2018-01-15 13:45:03 -0500 |
| commit | 28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f (patch) | |
| tree | 78f7165cb7332eafcc5269525f01416de38683d9 /include/linux/phy.h | |
| parent | febafc8455fdbb0ba53d596075068a683b75f355 (diff) | |
| download | linux-stable-28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f.tar.gz linux-stable-28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f.tar.bz2 linux-stable-28b2e0d2cd132284ad69fcea4b7cf6b7d0662c2f.zip | |
net: phy: remove parameter new_link from phy_mac_interrupt()
I see two issues with parameter new_link:
1. It's not needed. See also phy_interrupt(), works w/o this parameter.
phy_mac_interrupt sets the state to PHY_CHANGELINK and triggers the
state machine which then calls phy_read_status. And phy_read_status
updates the link state.
2. phy_mac_interrupt is used in interrupt context and getting the link
state may sleep (at least when having to access the PHY registers
via MDIO bus).
So let's remove it.
Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Tested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Diffstat (limited to 'include/linux/phy.h')
| -rw-r--r-- | include/linux/phy.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/linux/phy.h b/include/linux/phy.h index 135aba5c3d39..47715a3115b0 100644 --- a/include/linux/phy.h +++ b/include/linux/phy.h @@ -964,7 +964,7 @@ int phy_drivers_register(struct phy_driver *new_driver, int n, void phy_state_machine(struct work_struct *work); void phy_change(struct phy_device *phydev); void phy_change_work(struct work_struct *work); -void phy_mac_interrupt(struct phy_device *phydev, int new_link); +void phy_mac_interrupt(struct phy_device *phydev); void phy_start_machine(struct phy_device *phydev); void phy_stop_machine(struct phy_device *phydev); void phy_trigger_machine(struct phy_device *phydev, bool sync); |