diff options
author | Nicholas Mc Guire <hofrat@osadl.org> | 2015-05-27 08:56:25 +0200 |
---|---|---|
committer | Paul E. McKenney <paulmck@linux.vnet.ibm.com> | 2015-07-15 14:43:53 -0700 |
commit | f765d1130700878c2275bc1ea09eed428f870a2a (patch) | |
tree | 76a7baeb60e484fe1b6a587251632fc5b852c471 /include/linux/rcutiny.h | |
parent | d5671f6bf2a672cfa72ef2cbac5cc53a4539690d (diff) | |
download | linux-stable-f765d1130700878c2275bc1ea09eed428f870a2a.tar.gz linux-stable-f765d1130700878c2275bc1ea09eed428f870a2a.tar.bz2 linux-stable-f765d1130700878c2275bc1ea09eed428f870a2a.zip |
rcu: Change return type to bool
Type-checking coccinelle spatches are being used to locate type mismatches
between function signatures and return values in this case this produced:
./kernel/rcu/srcu.c:271 WARNING: return of wrong type
int != unsigned long,
srcu_readers_active() returns an int that is the sum of per_cpu unsigned
long but the only user is cleanup_srcu_struct() which is using it as a
boolean (condition) to see if there is any readers rather than actually
using the approximate number of readers. The theoretically possible
unsigned long overflow case does not need to be handled explicitly - if
we had 4G++ readers then something else went wrong a long time ago.
proposal: change the return type to boolean. The function name is left
unchanged as it fits the naming expectation for a boolean.
patch was compile tested for x86_64_defconfig (implies CONFIG_SRCU=y)
patch is against 4.1-rc5 (localversion-next is -next-20150525)
Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'include/linux/rcutiny.h')
0 files changed, 0 insertions, 0 deletions