diff options
| author | John Stultz <john.stultz@linaro.org> | 2011-01-03 18:59:43 -0800 |
|---|---|---|
| committer | John Stultz <john.stultz@linaro.org> | 2011-04-26 14:01:42 -0700 |
| commit | 88d19cf37952a7e1e38b2bf87a00f0e857e63180 (patch) | |
| tree | fdd409b1588005bb71b3cd0bf5fbe55a3dd68643 /include/linux | |
| parent | 304529b1b6f8612ccbb4582e997051b48b94f4a4 (diff) | |
| download | linux-stable-88d19cf37952a7e1e38b2bf87a00f0e857e63180.tar.gz linux-stable-88d19cf37952a7e1e38b2bf87a00f0e857e63180.tar.bz2 linux-stable-88d19cf37952a7e1e38b2bf87a00f0e857e63180.zip | |
timers: Add rb_init_node() to allow for stack allocated rb nodes
In cases where a timerqueue_node or some structure that utilizes
a timerqueue_node is allocated on the stack, gcc would give warnings
caused by the timerqueue_init()'s calling RB_CLEAR_NODE, which
self-references the nodes uninitialized data.
The solution is to create an rb_init_node() function that zeros
the rb_node structure out and then calls RB_CLEAR_NODE(), and
then call the new init function from timerqueue_init().
CC: Thomas Gleixner <tglx@linutronix.de>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: John Stultz <john.stultz@linaro.org>
Diffstat (limited to 'include/linux')
| -rw-r--r-- | include/linux/rbtree.h | 8 | ||||
| -rw-r--r-- | include/linux/timerqueue.h | 2 |
2 files changed, 9 insertions, 1 deletions
diff --git a/include/linux/rbtree.h b/include/linux/rbtree.h index 7066acb2c530..033b507b33b1 100644 --- a/include/linux/rbtree.h +++ b/include/linux/rbtree.h @@ -136,6 +136,14 @@ static inline void rb_set_color(struct rb_node *rb, int color) #define RB_EMPTY_NODE(node) (rb_parent(node) == node) #define RB_CLEAR_NODE(node) (rb_set_parent(node, node)) +static inline void rb_init_node(struct rb_node *rb) +{ + rb->rb_parent_color = 0; + rb->rb_right = NULL; + rb->rb_left = NULL; + RB_CLEAR_NODE(rb); +} + extern void rb_insert_color(struct rb_node *, struct rb_root *); extern void rb_erase(struct rb_node *, struct rb_root *); diff --git a/include/linux/timerqueue.h b/include/linux/timerqueue.h index a520fd70a59f..5088727478fd 100644 --- a/include/linux/timerqueue.h +++ b/include/linux/timerqueue.h @@ -39,7 +39,7 @@ struct timerqueue_node *timerqueue_getnext(struct timerqueue_head *head) static inline void timerqueue_init(struct timerqueue_node *node) { - RB_CLEAR_NODE(&node->node); + rb_init_node(&node->node); } static inline void timerqueue_init_head(struct timerqueue_head *head) |