summaryrefslogtreecommitdiffstats
path: root/include/linux
diff options
context:
space:
mode:
authorH. Peter Anvin <hpa@zytor.com>2012-03-02 10:43:49 -0800
committerLinus Torvalds <torvalds@linux-foundation.org>2012-03-02 11:38:15 -0800
commit5189fa19a4b2b4c3bec37c3a019d446148827717 (patch)
tree968ba4d4dea7375cfedaf5f1e22c1885a8ea003b /include/linux
parentc8e252586f8d5de906385d8cf6385fee289a825e (diff)
downloadlinux-stable-5189fa19a4b2b4c3bec37c3a019d446148827717.tar.gz
linux-stable-5189fa19a4b2b4c3bec37c3a019d446148827717.tar.bz2
linux-stable-5189fa19a4b2b4c3bec37c3a019d446148827717.zip
regset: Return -EFAULT, not -EIO, on host-side memory fault
There is only one error code to return for a bad user-space buffer pointer passed to a system call in the same address space as the system call is executed, and that is EFAULT. Furthermore, the low-level access routines, which catch most of the faults, return EFAULT already. Signed-off-by: H. Peter Anvin <hpa@zytor.com> Reviewed-by: Oleg Nesterov <oleg@redhat.com> Acked-by: Roland McGrath <roland@hack.frob.com> Cc: <stable@vger.kernel.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Diffstat (limited to 'include/linux')
-rw-r--r--include/linux/regset.h4
1 files changed, 2 insertions, 2 deletions
diff --git a/include/linux/regset.h b/include/linux/regset.h
index 5150fd16ef93..686f37327a49 100644
--- a/include/linux/regset.h
+++ b/include/linux/regset.h
@@ -339,7 +339,7 @@ static inline int copy_regset_to_user(struct task_struct *target,
return -EOPNOTSUPP;
if (!access_ok(VERIFY_WRITE, data, size))
- return -EIO;
+ return -EFAULT;
return regset->get(target, regset, offset, size, NULL, data);
}
@@ -365,7 +365,7 @@ static inline int copy_regset_from_user(struct task_struct *target,
return -EOPNOTSUPP;
if (!access_ok(VERIFY_READ, data, size))
- return -EIO;
+ return -EFAULT;
return regset->set(target, regset, offset, size, NULL, data);
}