diff options
| author | Jakub Kicinski <kuba@kernel.org> | 2020-08-26 12:40:06 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-09-12 11:47:40 +0200 |
| commit | 6048d57b66d724a3aa0faf52bf3eb2126396450f (patch) | |
| tree | 4aeed4a4693c3b5dd0a0fbd22bc8d162c4e8102a /include/net/route.h | |
| parent | 20e63db77149deb52d76ff9c8e7ddd3349c390ea (diff) | |
| download | linux-stable-6048d57b66d724a3aa0faf52bf3eb2126396450f.tar.gz linux-stable-6048d57b66d724a3aa0faf52bf3eb2126396450f.tar.bz2 linux-stable-6048d57b66d724a3aa0faf52bf3eb2126396450f.zip | |
net: disable netpoll on fresh napis
[ Upstream commit 96e97bc07e90f175a8980a22827faf702ca4cb30 ]
napi_disable() makes sure to set the NAPI_STATE_NPSVC bit to prevent
netpoll from accessing rings before init is complete. However, the
same is not done for fresh napi instances in netif_napi_add(),
even though we expect NAPI instances to be added as disabled.
This causes crashes during driver reconfiguration (enabling XDP,
changing the channel count) - if there is any printk() after
netif_napi_add() but before napi_enable().
To ensure memory ordering is correct we need to use RCU accessors.
Reported-by: Rob Sherwood <rsher@fb.com>
Fixes: 2d8bff12699a ("netpoll: Close race condition between poll_one_napi and napi_disable")
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'include/net/route.h')
0 files changed, 0 insertions, 0 deletions