diff options
| author | Stefan Binding <sbinding@opensource.cirrus.com> | 2023-10-26 16:05:58 +0100 |
|---|---|---|
| committer | Takashi Iwai <tiwai@suse.de> | 2023-10-26 17:55:29 +0200 |
| commit | 76c121821a3128eb9d0183a525cf334beb9ccc47 (patch) | |
| tree | 90896d4b53992210cc85c6fed22b958bbb67d929 /include/sound | |
| parent | a51d8ba03a4fc92940d5e349f0325f36e85a89cb (diff) | |
| download | linux-stable-76c121821a3128eb9d0183a525cf334beb9ccc47.tar.gz linux-stable-76c121821a3128eb9d0183a525cf334beb9ccc47.tar.bz2 linux-stable-76c121821a3128eb9d0183a525cf334beb9ccc47.zip | |
ASoC: cs35l41: Detect CSPL errors when sending CSPL commands
The existing code checks for the correct state transition after sending
a command. However, it is possible for the message box to return -1,
which indicates an error, if an error has occurred in the firmware.
We can detect if the error has occurred, and return a different error.
In addition, there is no recovering from a CSPL error, so the retry
mechanism is not needed in this case, and we can return immediately.
Signed-off-by: Stefan Binding <sbinding@opensource.cirrus.com>
Acked-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20231026150558.2105827-9-sbinding@opensource.cirrus.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Diffstat (limited to 'include/sound')
| -rw-r--r-- | include/sound/cs35l41.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/include/sound/cs35l41.h b/include/sound/cs35l41.h index 80df80fe31e2..043f8ac65dbf 100644 --- a/include/sound/cs35l41.h +++ b/include/sound/cs35l41.h @@ -816,6 +816,8 @@ struct cs35l41_otp_map_element_t { }; enum cs35l41_cspl_mbox_status { + CSPL_MBOX_STS_ERROR = U32_MAX, + CSPL_MBOX_STS_ERROR2 = 0x00ffffff, // firmware not always sign-extending 24-bit value CSPL_MBOX_STS_RUNNING = 0, CSPL_MBOX_STS_PAUSED = 1, CSPL_MBOX_STS_RDY_FOR_REINIT = 2, |