diff options
| author | Eric Dumazet <edumazet@google.com> | 2019-10-09 15:10:15 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2020-01-27 14:51:18 +0100 |
| commit | a92c895e22b738454f06651f3aa4d8f441157f18 (patch) | |
| tree | 32ea93a9c2aba22f37148e89ddfa35a017ff6d43 /include | |
| parent | b0fb910bfdf469fa5016e939c778cfb566be2e33 (diff) | |
| download | linux-stable-a92c895e22b738454f06651f3aa4d8f441157f18.tar.gz linux-stable-a92c895e22b738454f06651f3aa4d8f441157f18.tar.bz2 linux-stable-a92c895e22b738454f06651f3aa4d8f441157f18.zip | |
tcp: annotate lockless access to tcp_memory_pressure
[ Upstream commit 1f142c17d19a5618d5a633195a46f2c8be9bf232 ]
tcp_memory_pressure is read without holding any lock,
and its value could be changed on other cpus.
Use READ_ONCE() to annotate these lockless reads.
The write side is already using atomic ops.
Fixes: b8da51ebb1aa ("tcp: introduce tcp_under_memory_pressure()")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'include')
| -rw-r--r-- | include/net/tcp.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/include/net/tcp.h b/include/net/tcp.h index ac4ffe8013d8..918bfd0d7d1f 100644 --- a/include/net/tcp.h +++ b/include/net/tcp.h @@ -261,7 +261,7 @@ static inline bool tcp_under_memory_pressure(const struct sock *sk) mem_cgroup_under_socket_pressure(sk->sk_memcg)) return true; - return tcp_memory_pressure; + return READ_ONCE(tcp_memory_pressure); } /* * The next routines deal with comparing 32 bit unsigned ints |