diff options
author | Chengfeng Ye <dg573847474@gmail.com> | 2023-07-27 08:56:19 +0000 |
---|---|---|
committer | Jakub Kicinski <kuba@kernel.org> | 2023-07-28 18:49:28 -0700 |
commit | 56c6be35fcbed54279df0a2c9e60480a61841d6f (patch) | |
tree | 564a7db3134535851d269e567ba8ddec5e243a7c /include | |
parent | e68409db995380d1badacba41ff24996bd396171 (diff) | |
download | linux-stable-56c6be35fcbed54279df0a2c9e60480a61841d6f.tar.gz linux-stable-56c6be35fcbed54279df0a2c9e60480a61841d6f.tar.bz2 linux-stable-56c6be35fcbed54279df0a2c9e60480a61841d6f.zip |
mISDN: hfcpci: Fix potential deadlock on &hc->lock
As &hc->lock is acquired by both timer _hfcpci_softirq() and hardirq
hfcpci_int(), the timer should disable irq before lock acquisition
otherwise deadlock could happen if the timmer is preemtped by the hadr irq.
Possible deadlock scenario:
hfcpci_softirq() (timer)
-> _hfcpci_softirq()
-> spin_lock(&hc->lock);
<irq interruption>
-> hfcpci_int()
-> spin_lock(&hc->lock); (deadlock here)
This flaw was found by an experimental static analysis tool I am developing
for irq-related deadlock.
The tentative patch fixes the potential deadlock by spin_lock_irq()
in timer.
Fixes: b36b654a7e82 ("mISDN: Create /sys/class/mISDN")
Signed-off-by: Chengfeng Ye <dg573847474@gmail.com>
Link: https://lore.kernel.org/r/20230727085619.7419-1-dg573847474@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Diffstat (limited to 'include')
0 files changed, 0 insertions, 0 deletions