summaryrefslogtreecommitdiffstats
path: root/init
diff options
context:
space:
mode:
authorSong Liu <songliubraving@fb.com>2018-03-05 21:55:04 -0800
committerIngo Molnar <mingo@kernel.org>2018-03-09 08:03:02 +0100
commitbd903afeb504db5655a45bb4cf86f38be5b1bf62 (patch)
tree1b3cd44a782b5f5c47f55be5c74e95a921250a98 /init
parent629ae2ee73e225fa7dcce581c005d773b0190dcc (diff)
downloadlinux-stable-bd903afeb504db5655a45bb4cf86f38be5b1bf62.tar.gz
linux-stable-bd903afeb504db5655a45bb4cf86f38be5b1bf62.tar.bz2
linux-stable-bd903afeb504db5655a45bb4cf86f38be5b1bf62.zip
perf/core: Fix ctx_event_type in ctx_resched()
In ctx_resched(), EVENT_FLEXIBLE should be sched_out when EVENT_PINNED is added. However, ctx_resched() calculates ctx_event_type before checking this condition. As a result, pinned events will NOT get higher priority than flexible events. The following shows this issue on an Intel CPU (where ref-cycles can only use one hardware counter). 1. First start: perf stat -C 0 -e ref-cycles -I 1000 2. Then, in the second console, run: perf stat -C 0 -e ref-cycles:D -I 1000 The second perf uses pinned events, which is expected to have higher priority. However, because it failed in ctx_resched(). It is never run. This patch fixes this by calculating ctx_event_type after re-evaluating event_type. Reported-by: Ephraim Park <ephiepark@fb.com> Signed-off-by: Song Liu <songliubraving@fb.com> Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org> Cc: <jolsa@redhat.com> Cc: <kernel-team@fb.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Stephane Eranian <eranian@google.com> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Vince Weaver <vincent.weaver@maine.edu> Fixes: 487f05e18aa4 ("perf/core: Optimize event rescheduling on active contexts") Link: http://lkml.kernel.org/r/20180306055504.3283731-1-songliubraving@fb.com Signed-off-by: Ingo Molnar <mingo@kernel.org>
Diffstat (limited to 'init')
0 files changed, 0 insertions, 0 deletions