summaryrefslogtreecommitdiffstats
path: root/kernel/bpf
diff options
context:
space:
mode:
authorStephen Suryaputra <ssuryaextr@gmail.com>2020-08-04 17:44:09 -0400
committerPablo Neira Ayuso <pablo@netfilter.org>2020-08-10 13:02:43 +0200
commitb428336676dbca363262cc134b6218205df4f530 (patch)
treed076b09df1ca64787fee763874a2b9657c7704ca /kernel/bpf
parent7c7ab580db49cc7befe5f4b91bb1920cd6b07575 (diff)
downloadlinux-stable-b428336676dbca363262cc134b6218205df4f530.tar.gz
linux-stable-b428336676dbca363262cc134b6218205df4f530.tar.bz2
linux-stable-b428336676dbca363262cc134b6218205df4f530.zip
netfilter: nf_tables: nft_exthdr: the presence return value should be little-endian
On big-endian machine, the returned register data when the exthdr is present is not being compared correctly because little-endian is assumed. The function nft_cmp_fast_mask(), called by nft_cmp_fast_eval() and nft_cmp_fast_init(), calls cpu_to_le32(). The following dump also shows that little endian is assumed: $ nft --debug=netlink add rule ip recordroute forward ip option rr exists counter ip [ exthdr load ipv4 1b @ 7 + 0 present => reg 1 ] [ cmp eq reg 1 0x01000000 ] [ counter pkts 0 bytes 0 ] Lastly, debug print in nft_cmp_fast_init() and nft_cmp_fast_eval() when RR option exists in the packet shows that the comparison fails because the assumption: nft_cmp_fast_init:189 priv->sreg=4 desc.len=8 mask=0xff000000 data.data[0]=0x10003e0 nft_cmp_fast_eval:57 regs->data[priv->sreg=4]=0x1 mask=0xff000000 priv->data=0x1000000 v2: use nft_reg_store8() instead (Florian Westphal). Also to avoid the warnings reported by kernel test robot. Fixes: dbb5281a1f84 ("netfilter: nf_tables: add support for matching IPv4 options") Fixes: c078ca3b0c5b ("netfilter: nft_exthdr: Add support for existence check") Signed-off-by: Stephen Suryaputra <ssuryaextr@gmail.com> Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Diffstat (limited to 'kernel/bpf')
0 files changed, 0 insertions, 0 deletions