diff options
author | Linus Torvalds <torvalds@linux-foundation.org> | 2020-12-15 19:36:48 -0800 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2020-12-15 19:36:48 -0800 |
commit | d01e7f10dae29eba0f9ada82b65d24e035d5b2f9 (patch) | |
tree | 5f8260e02bf6290fe386337e4c66858eaf20340d /kernel/fork.c | |
parent | faf145d6f3f3d6f2c066f65602ba9d0a03106915 (diff) | |
parent | f7cfd871ae0c5008d94b6f66834e7845caa93c15 (diff) | |
download | linux-stable-d01e7f10dae29eba0f9ada82b65d24e035d5b2f9.tar.gz linux-stable-d01e7f10dae29eba0f9ada82b65d24e035d5b2f9.tar.bz2 linux-stable-d01e7f10dae29eba0f9ada82b65d24e035d5b2f9.zip |
Merge branch 'exec-update-lock-for-v5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace
Pull exec-update-lock update from Eric Biederman:
"The key point of this is to transform exec_update_mutex into a
rw_semaphore so readers can be separated from writers.
This makes it easier to understand what the holders of the lock are
doing, and makes it harder to contend or deadlock on the lock.
The real deadlock fix wound up in perf_event_open"
* 'exec-update-lock-for-v5.11' of git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace:
exec: Transform exec_update_mutex into a rw_semaphore
Diffstat (limited to 'kernel/fork.c')
-rw-r--r-- | kernel/fork.c | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/kernel/fork.c b/kernel/fork.c index 4f44d87b82ef..41906a52a764 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -1225,7 +1225,7 @@ struct mm_struct *mm_access(struct task_struct *task, unsigned int mode) struct mm_struct *mm; int err; - err = mutex_lock_killable(&task->signal->exec_update_mutex); + err = down_read_killable(&task->signal->exec_update_lock); if (err) return ERR_PTR(err); @@ -1235,7 +1235,7 @@ struct mm_struct *mm_access(struct task_struct *task, unsigned int mode) mmput(mm); mm = ERR_PTR(-EACCES); } - mutex_unlock(&task->signal->exec_update_mutex); + up_read(&task->signal->exec_update_lock); return mm; } @@ -1595,7 +1595,7 @@ static int copy_signal(unsigned long clone_flags, struct task_struct *tsk) sig->oom_score_adj_min = current->signal->oom_score_adj_min; mutex_init(&sig->cred_guard_mutex); - mutex_init(&sig->exec_update_mutex); + init_rwsem(&sig->exec_update_lock); return 0; } |