diff options
| author | Christoph Hellwig <hch@lst.de> | 2021-02-02 13:13:26 +0100 |
|---|---|---|
| committer | Jessica Yu <jeyu@kernel.org> | 2021-02-08 12:22:08 +0100 |
| commit | 013c1667cf78c1d847152f7116436d82dcab3db4 (patch) | |
| tree | 14ff7b6f382399544e4dbc530dfadf9b6748e3c6 /kernel/livepatch | |
| parent | a006050575745ca2be25118b90f1c37f454ac542 (diff) | |
| download | linux-stable-013c1667cf78c1d847152f7116436d82dcab3db4.tar.gz linux-stable-013c1667cf78c1d847152f7116436d82dcab3db4.tar.bz2 linux-stable-013c1667cf78c1d847152f7116436d82dcab3db4.zip | |
kallsyms: refactor {,module_}kallsyms_on_each_symbol
Require an explicit call to module_kallsyms_on_each_symbol to look
for symbols in modules instead of the call from kallsyms_on_each_symbol,
and acquire module_mutex inside of module_kallsyms_on_each_symbol instead
of leaving that up to the caller. Note that this slightly changes the
behavior for the livepatch code in that the symbols from vmlinux are not
iterated anymore if objname is set, but that actually is the desired
behavior in this case.
Reviewed-by: Petr Mladek <pmladek@suse.com>
Acked-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Jessica Yu <jeyu@kernel.org>
Diffstat (limited to 'kernel/livepatch')
| -rw-r--r-- | kernel/livepatch/core.c | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c index 262cd9b003b9..335d988bd811 100644 --- a/kernel/livepatch/core.c +++ b/kernel/livepatch/core.c @@ -164,12 +164,10 @@ static int klp_find_object_symbol(const char *objname, const char *name, .pos = sympos, }; - mutex_lock(&module_mutex); if (objname) module_kallsyms_on_each_symbol(klp_find_callback, &args); else kallsyms_on_each_symbol(klp_find_callback, &args); - mutex_unlock(&module_mutex); /* * Ensure an address was found. If sympos is 0, ensure symbol is unique; |