diff options
| author | Dietmar Eggemann <dietmar.eggemann@arm.com> | 2019-08-02 15:59:43 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2019-08-29 08:30:14 +0200 |
| commit | a343eca8fd929d86ed50f3978d4e3272cdbb6c37 (patch) | |
| tree | 11778bb4a53963c03336157b98f502a2681ec980 /kernel/locking | |
| parent | 4fe7ee5ed9b045c2c8e54bac39daba265aa288e0 (diff) | |
| download | linux-stable-a343eca8fd929d86ed50f3978d4e3272cdbb6c37.tar.gz linux-stable-a343eca8fd929d86ed50f3978d4e3272cdbb6c37.tar.bz2 linux-stable-a343eca8fd929d86ed50f3978d4e3272cdbb6c37.zip | |
sched/deadline: Fix double accounting of rq/running bw in push & pull
[ Upstream commit f4904815f97a934258445a8f763f6b6c48f007e7 ]
{push,pull}_dl_task() always calls {de,}activate_task() with .flags=0
which sets p->on_rq=TASK_ON_RQ_MIGRATING.
{push,pull}_dl_task()->{de,}activate_task()->{de,en}queue_task()->
{de,en}queue_task_dl() calls {sub,add}_{running,rq}_bw() since
p->on_rq==TASK_ON_RQ_MIGRATING.
So {sub,add}_{running,rq}_bw() in {push,pull}_dl_task() is
double-accounting for that task.
Fix it by removing rq/running bw accounting in [push/pull]_dl_task().
Fixes: 7dd778841164 ("sched/core: Unify p->on_rq updates")
Signed-off-by: Dietmar Eggemann <dietmar.eggemann@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Cc: Valentin Schneider <valentin.schneider@arm.com>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Luca Abeni <luca.abeni@santannapisa.it>
Cc: Daniel Bristot de Oliveira <bristot@redhat.com>
Cc: Juri Lelli <juri.lelli@redhat.com>
Cc: Qais Yousef <qais.yousef@arm.com>
Link: https://lkml.kernel.org/r/20190802145945.18702-2-dietmar.eggemann@arm.com
Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'kernel/locking')
0 files changed, 0 insertions, 0 deletions