summaryrefslogtreecommitdiffstats
path: root/kernel/rcu/tree_plugin.h
diff options
context:
space:
mode:
authorPranith Kumar <bobby.prani@gmail.com>2014-08-12 13:07:47 -0400
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>2014-09-07 16:18:19 -0700
commit2aa792e6faf1a00f5accf1f69e87e11a390ba2cd (patch)
tree9cae97455e0258207ed4045558584930df75209a /kernel/rcu/tree_plugin.h
parentade9862470dd0595d8e292ecea8445ed90b98df5 (diff)
downloadlinux-stable-2aa792e6faf1a00f5accf1f69e87e11a390ba2cd.tar.gz
linux-stable-2aa792e6faf1a00f5accf1f69e87e11a390ba2cd.tar.bz2
linux-stable-2aa792e6faf1a00f5accf1f69e87e11a390ba2cd.zip
rcu: Use rcu_gp_kthread_wake() to wake up grace period kthreads
The rcu_gp_kthread_wake() function checks for three conditions before waking up grace period kthreads: * Is the thread we are trying to wake up the current thread? * Are the gp_flags zero? (all threads wait on non-zero gp_flags condition) * Is there no thread created for this flavour, hence nothing to wake up? If any one of these condition is true, we do not call wake_up(). It was found that there are quite a few avoidable wake ups both during idle time and under stress induced by rcutorture. Idle: Total:66000, unnecessary:66000, case1:61827, case2:66000, case3:0 Total:68000, unnecessary:68000, case1:63696, case2:68000, case3:0 rcutorture: Total:254000, unnecessary:254000, case1:199913, case2:254000, case3:0 Total:256000, unnecessary:256000, case1:201784, case2:256000, case3:0 Here case{1-3} are the cases listed above. We can avoid these wake ups by using rcu_gp_kthread_wake() to conditionally wake up the grace period kthreads. There is a comment about an implied barrier supplied by the wake_up() logic. This barrier is necessary for the awakened thread to see the updated ->gp_flags. This flag is always being updated with the root node lock held. Also, the awakened thread tries to acquire the root node lock before reading ->gp_flags because of which there is proper ordering. Hence this commit tries to avoid calling wake_up() whenever we can by using rcu_gp_kthread_wake() function. Signed-off-by: Pranith Kumar <bobby.prani@gmail.com> CC: Mathieu Desnoyers <mathieu.desnoyers@efficios.com> Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Diffstat (limited to 'kernel/rcu/tree_plugin.h')
0 files changed, 0 insertions, 0 deletions