summaryrefslogtreecommitdiffstats
path: root/kernel
diff options
context:
space:
mode:
authorZhen Lei <thunder.leizhen@huawei.com>2021-08-11 17:33:32 +0800
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2021-09-15 09:50:29 +0200
commite9a902f88207fd2fae394357af1e596a74ac2281 (patch)
tree85a13cd9ba8276c3cbc31570f53c6d62a4c3e5c7 /kernel
parent10d3bdd2d57867a98473a0a4bc153262e9b902b9 (diff)
downloadlinux-stable-e9a902f88207fd2fae394357af1e596a74ac2281.tar.gz
linux-stable-e9a902f88207fd2fae394357af1e596a74ac2281.tar.bz2
linux-stable-e9a902f88207fd2fae394357af1e596a74ac2281.zip
genirq/timings: Fix error return code in irq_timings_test_irqs()
[ Upstream commit 290fdc4b7ef14e33d0e30058042b0e9bfd02b89b ] Return a negative error code from the error handling case instead of 0, as done elsewhere in this function. Fixes: f52da98d900e ("genirq/timings: Add selftest for irqs circular buffer") Reported-by: Hulk Robot <hulkci@huawei.com> Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/r/20210811093333.2376-1-thunder.leizhen@huawei.com Signed-off-by: Sasha Levin <sashal@kernel.org>
Diffstat (limited to 'kernel')
-rw-r--r--kernel/irq/timings.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/kernel/irq/timings.c b/kernel/irq/timings.c
index 6990490fa67b..1f981162648a 100644
--- a/kernel/irq/timings.c
+++ b/kernel/irq/timings.c
@@ -799,12 +799,14 @@ static int __init irq_timings_test_irqs(struct timings_intervals *ti)
__irq_timings_store(irq, irqs, ti->intervals[i]);
if (irqs->circ_timings[i & IRQ_TIMINGS_MASK] != index) {
+ ret = -EBADSLT;
pr_err("Failed to store in the circular buffer\n");
goto out;
}
}
if (irqs->count != ti->count) {
+ ret = -ERANGE;
pr_err("Count differs\n");
goto out;
}