diff options
author | Eric Biggers <ebiggers@google.com> | 2017-11-07 14:15:27 -0800 |
---|---|---|
committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2017-11-30 08:40:39 +0000 |
commit | ce922b7b4a5178279eb5453e7fcb0b116c757f1e (patch) | |
tree | 1a9d540b26bcb6279da69893c24c9cf79462fac3 /lib/smp_processor_id.c | |
parent | 9f088f6a6752c18ceb1338e07b7b702a0b086914 (diff) | |
download | linux-stable-ce922b7b4a5178279eb5453e7fcb0b116c757f1e.tar.gz linux-stable-ce922b7b4a5178279eb5453e7fcb0b116c757f1e.tar.bz2 linux-stable-ce922b7b4a5178279eb5453e7fcb0b116c757f1e.zip |
lib/mpi: call cond_resched() from mpi_powm() loop
commit 1d9ddde12e3c9bab7f3d3484eb9446315e3571ca upstream.
On a non-preemptible kernel, if KEYCTL_DH_COMPUTE is called with the
largest permitted inputs (16384 bits), the kernel spends 10+ seconds
doing modular exponentiation in mpi_powm() without rescheduling. If all
threads do it, it locks up the system. Moreover, it can cause
rcu_sched-stall warnings.
Notwithstanding the insanity of doing this calculation in kernel mode
rather than in userspace, fix it by calling cond_resched() as each bit
from the exponent is processed. It's still noninterruptible, but at
least it's preemptible now.
Do the cond_resched() once per bit rather than once per MPI limb because
each limb might still easily take 100+ milliseconds on slow CPUs.
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib/smp_processor_id.c')
0 files changed, 0 insertions, 0 deletions