diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2018-07-01 13:57:16 -0700 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2018-12-08 13:03:35 +0100 |
| commit | af882cb0bcb5573014e2203dbfd67e2737bb10d3 (patch) | |
| tree | 44633c6df2e783f81bbcecb22cf02e58fb17f778 /lib | |
| parent | 337f2837c5b29c1587dd7efc4befc9f6f84a2746 (diff) | |
| download | linux-stable-af882cb0bcb5573014e2203dbfd67e2737bb10d3.tar.gz linux-stable-af882cb0bcb5573014e2203dbfd67e2737bb10d3.tar.bz2 linux-stable-af882cb0bcb5573014e2203dbfd67e2737bb10d3.zip | |
kobject: Replace strncpy with memcpy
commit 77d2a24b6107bd9b3bf2403a65c1428a9da83dd0 upstream.
gcc 8.1.0 complains:
lib/kobject.c:128:3: warning:
'strncpy' output truncated before terminating nul copying as many
bytes from a string as its length [-Wstringop-truncation]
lib/kobject.c: In function 'kobject_get_path':
lib/kobject.c:125:13: note: length computed here
Using strncpy() is indeed less than perfect since the length of data to
be copied has already been determined with strlen(). Replace strncpy()
with memcpy() to address the warning and optimize the code a little.
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Diffstat (limited to 'lib')
| -rw-r--r-- | lib/kobject.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/lib/kobject.c b/lib/kobject.c index 34f847252c02..bbbb067de8ec 100644 --- a/lib/kobject.c +++ b/lib/kobject.c @@ -127,7 +127,7 @@ static void fill_kobj_path(struct kobject *kobj, char *path, int length) int cur = strlen(kobject_name(parent)); /* back up enough to print this name with '/' */ length -= cur; - strncpy(path + length, kobject_name(parent), cur); + memcpy(path + length, kobject_name(parent), cur); *(path + --length) = '/'; } |