diff options
| author | Eric Dumazet <edumazet@google.com> | 2018-11-17 21:57:02 -0800 |
|---|---|---|
| committer | Ben Hutchings <ben@decadent.org.uk> | 2019-02-11 17:54:05 +0000 |
| commit | 843e4e5864440e03aa7fe5fc76df9139a92fa359 (patch) | |
| tree | ba8f8230d7b2e2952b290953ead65a5200383b02 /mm/hugetlb.c | |
| parent | ab77f8541e7116a4d5f127f9eda2a4f87709fa0f (diff) | |
| download | linux-stable-843e4e5864440e03aa7fe5fc76df9139a92fa359.tar.gz linux-stable-843e4e5864440e03aa7fe5fc76df9139a92fa359.tar.bz2 linux-stable-843e4e5864440e03aa7fe5fc76df9139a92fa359.zip | |
net-gro: reset skb->pkt_type in napi_reuse_skb()
commit 33d9a2c72f086cbf1087b2fd2d1a15aa9df14a7f upstream.
eth_type_trans() assumes initial value for skb->pkt_type
is PACKET_HOST.
This is indeed the value right after a fresh skb allocation.
However, it is possible that GRO merged a packet with a different
value (like PACKET_OTHERHOST in case macvlan is used), so
we need to make sure napi->skb will have pkt_type set back to
PACKET_HOST.
Otherwise, valid packets might be dropped by the stack because
their pkt_type is not PACKET_HOST.
napi_reuse_skb() was added in commit 96e93eab2033 ("gro: Add
internal interfaces for VLAN"), but this bug always has
been there.
Fixes: 96e93eab2033 ("gro: Add internal interfaces for VLAN")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Diffstat (limited to 'mm/hugetlb.c')
0 files changed, 0 insertions, 0 deletions