diff options
author | Laurent Pinchart <laurent.pinchart@ideasonboard.com> | 2014-06-03 18:53:25 -0300 |
---|---|---|
committer | Mauro Carvalho Chehab <m.chehab@samsung.com> | 2014-07-17 16:19:04 -0300 |
commit | 4bb7267dc41247810815e8b15f0e9fb1456c8d8c (patch) | |
tree | 04379e02986bc6de1d6d395a9f66b33c27cef9b0 /mm/slob.c | |
parent | 9241650d62f79a3da01f1d5e8ebd195083330b75 (diff) | |
download | linux-stable-4bb7267dc41247810815e8b15f0e9fb1456c8d8c.tar.gz linux-stable-4bb7267dc41247810815e8b15f0e9fb1456c8d8c.tar.bz2 linux-stable-4bb7267dc41247810815e8b15f0e9fb1456c8d8c.zip |
[media] v4l: vb2: Add fatal error condition flag
When a fatal error occurs that render the device unusable, the only
options for a driver to signal the error condition to userspace is to
set the V4L2_BUF_FLAG_ERROR flag when dequeuing buffers and to return an
error from the buffer prepare handler when queuing buffers.
The buffer error flag indicates a transient error and can't be used by
applications to detect fatal errors. Returning an error from vb2_qbuf()
is thus the only real indication that a fatal error occurred. However,
this is difficult to handle for multithreaded applications that requeue
buffers from a thread other than the control thread. In particular the
poll() call in the control thread will not notify userspace of the
error.
This patch adds an explicit mechanism to report fatal errors to
userspace. Drivers can call the vb2_queue_error() function to signal a
fatal error. From this moment on, buffer preparation will return -EIO to
userspace, and vb2_poll() will set the POLLERR flag and return
immediately. The error flag is cleared when cancelling the queue, either
at stream off time (through vb2_streamoff) or when releasing the queue
with vb2_queue_release().
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Acked-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <m.chehab@samsung.com>
Diffstat (limited to 'mm/slob.c')
0 files changed, 0 insertions, 0 deletions